Add shapes plugin #107
Merged
Add shapes plugin #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
|
Demo: |
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
chapulina
suggested changes
Apr 28, 2020
This was referenced Apr 29, 2020
Closed
added 4 commits
May 5, 2020 11:35
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
…cs/ign-gazebo into add_shapes_plugin
Fixed in dd864dd |
|
Ready for another iteration |
iche033
requested changes
May 8, 2020
Signed-off-by: John Shepherd <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo2 #107 +/- ##
==============================================
Coverage ? 62.38%
==============================================
Files ? 123
Lines ? 6091
Branches ? 0
==============================================
Hits ? 3800
Misses ? 2291
Partials ? 0 Continue to review full report at Codecov.
|
added 2 commits
May 12, 2020 13:32
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
iche033
reviewed
May 12, 2020
added 2 commits
May 12, 2020 15:30
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
iche033
approved these changes
May 13, 2020
azeey
pushed a commit
to azeey/gz-sim
that referenced
this pull request
May 20, 2020
Signed-off-by: John Shepherd <[email protected]>
nkoenig
added a commit
that referenced
this pull request
May 21, 2020
* Add shapes plugin (#107) Signed-off-by: John Shepherd <[email protected]> * Add option to suppress warning about missing child model (#132) Signed-off-by: Addisu Z. Taddese <[email protected]> * Support multi entity spawn (#146) * Support multi entity spawn Signed-off-by: Nate Koenig <[email protected]> * Added more documentation Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Bump ign-msgs version to 4.9 (#148) Signed-off-by: Louise Poubel <[email protected]> * Revert silly mistake Signed-off-by: Nate Koenig <[email protected]> * ign-msgs 5.3 dependency Signed-off-by: Nate Koenig <[email protected]> * Bump minor version Signed-off-by: Nate Koenig <[email protected]> * Changelog Signed-off-by: Nate Koenig <[email protected]> * RawPose Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: John <[email protected]> Co-authored-by: Addisu Taddese <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
azeey
pushed a commit
to azeey/gz-sim
that referenced
this pull request
May 28, 2020
Signed-off-by: John Shepherd <[email protected]> Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of ign-gazebo#95 so that PR will need to be merged before this one (it doesn't have to be, but I thought a separate PR for that functionality would be better for visibility and documentation purposes.There are a few things I made "prototypes" of that I would like to have looked and discussed for improvement:
UniqueId()HandleModelPlacement()good/could there be a better way to handle the mouse events here?There's currently a bug with this addition messing with the button pressing functionalities - I'll take a closer look at this soonResolves #81